Skip to content

[SPARK-9242][SQL] Audit UDAF interface. #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 1 commit into from
Closed

[SPARK-9242][SQL] Audit UDAF interface. #8321

rxin wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Aug 19, 2015

A few minor changes:

  1. Improved documentation
  2. Rename apply(distinct....) to distinct.
  3. Changed MutableAggregationBuffer from a trait to an abstract class.
  4. Renamed returnDataType to dataType to be more consistent with other expressions.

And unrelated to UDAFs:

  1. Renamed file names in expressions to use suffix "Expressions" to be more consistent.
  2. Moved regexp related expressions out to its own file.
  3. Renamed StringComparison => StringPredicate.

@yhuai
Copy link
Contributor

yhuai commented Aug 19, 2015

UDAF part looks good.

@SparkQA
Copy link

SparkQA commented Aug 20, 2015

Test build #1673 has finished for PR 8321 at commit 8d29a42.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 20, 2015
@rxin
[SPARK-9242] [SQL] Audit UDAF interface.
321cb99 
A few minor changes:

1. Improved documentation
2. Rename apply(distinct....) to distinct.
3. Changed MutableAggregationBuffer from a trait to an abstract class.
4. Renamed returnDataType to dataType to be more consistent with other expressions.

And unrelated to UDAFs:

1. Renamed file names in expressions to use suffix "Expressions" to be more consistent.
2. Moved regexp related expressions out to its own file.
3. Renamed StringComparison => StringPredicate.

Author: Reynold Xin <[email protected]>

Closes #8321 from rxin/SPARK-9242.

(cherry picked from commit 2f2686a)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 2f2686a Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @yhuai @SparkQA